Skip to content

make generate -- after changes in chainlink-protos#1595

Merged
cedric-cordenier merged 3 commits intomainfrom
confhttp2
Oct 10, 2025
Merged

make generate -- after changes in chainlink-protos#1595
cedric-cordenier merged 3 commits intomainfrom
confhttp2

Conversation

@nadahalli
Copy link
Copy Markdown
Contributor

Requires

Supports

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2025

👋 nadahalli, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2025

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-common

🔴 Breaking Changes (7)

pkg/capabilities/v2/actions/confidentialhttp (3)
  • Input — 🗑️ Removed

  • Output — 🗑️ Removed

  • OutputResponsesElem — 🗑️ Removed

pkg/capabilities/v2/actions/confidentialhttp.(*Request) (1)
  • GetPublicTemplateValues — Type changed:
- func() *google.golang.org/protobuf/types/known/structpb.Struct
+ func() map[string]string
pkg/capabilities/v2/actions/confidentialhttp.Request (1)
  • PublicTemplateValues — Type changed:
- *google.golang.org/protobuf/types/known/structpb.Struct
+ map[string]string
pkg/capabilities/v2/actions/confidentialhttp/server (1)
pkg/capabilities/v2/actions/confidentialhttp/server.ClientCapability (1)
  • SendRequests — Type changed:
- func(context.Context, github.com/smartcontractkit/chainlink-common/pkg/capabilities.RequestMetadata, *github.com/smartcontractkit/chainlink-common/pkg/capabilities/v2/actions/confidentialhttp.Input) (*github.com/smartcontractkit/chainlink-common/pkg/capabilities.ResponseAndMetadata[*github.com/smartcontractkit/chainlink-common/pkg/capabilities/v2/actions/confidentialhttp.Output], error)
+ func(context.Context, github.com/smartcontractkit/chainlink-common/pkg/capabilities.RequestMetadata, *github.com/smartcontractkit/chainlink-common/pkg/capabilities/v2/actions/confidentialhttp.EnclaveActionInput) (*github.com/smartcontractkit/chainlink-common/pkg/capabilities.ResponseAndMetadata[*github.com/smartcontractkit/chainlink-common/pkg/capabilities/v2/actions/confidentialhttp.HTTPEnclaveResponseData], error)

📄 View full apidiff report | 📚 Learn about apidiff

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 041948b Previous: d40f750 Ratio
BenchmarkKeystore_Sign/nop/in-process 728.5 ns/op 355.2 ns/op 2.05

This comment was automatically generated by workflow using github-action-benchmark.

@cedric-cordenier cedric-cordenier merged commit c1f318b into main Oct 10, 2025
21 of 23 checks passed
@cedric-cordenier cedric-cordenier deleted the confhttp2 branch October 10, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants